Date: Mon, 14 Oct 2013 23:21:39 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Julio Merino <julio@meroh.net> Cc: freebsd-testing@freebsd.org, Rui Paulo <rpaulo@fnop.net>, Garrett Cooper <yanegomi@gmail.com> Subject: Re: Refactoring of *.test.mk Message-ID: <20131015062139.DAD595807E@chaos.jnpr.net> In-Reply-To: <CADyfeQW5z6aWH1sfnGF5mbWGeHap-o4j7Y4ttqGRU5WDqMbABg@mail.gmail.com> References: <CADyfeQVTx3LUo3Q-bcPPmG3Xx4TPtRcJB1%2Bzk6ms_-zz%2Box6eg@mail.gmail.com> <CADyfeQW5z6aWH1sfnGF5mbWGeHap-o4j7Y4ttqGRU5WDqMbABg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks Julio,
looks good.
One nit; in hook-atf-run.diff and hook-kyua.diff I see:
+TESTS_ENV+= ATF_BUILD_CC=${DESTDIR}/usr/bin/cc
etc.
It would be safer to allow ATF_BUILD_CC etc to be controlled
eg.
TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC:U${DESTDIR}/usr/bin/cc}
..
or
ATF_BUILD_CC?= ${DESTDIR}/usr/bin/cc
..
TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC}
..
On Mon, 14 Oct 2013 23:24:39 -0400, Julio Merino writes:
>[Fixing Garrett's address...]
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131015062139.DAD595807E>