Date: Tue, 15 Apr 2014 13:17:48 -0600 (MDT) From: John Hein <john.hein@microsemi.com> To: FreeBSD-gnats-submit@freebsd.org Cc: gnome@freebsd.org Subject: ports/188670: [patch] update devel/seed (2.31.91) to build with both new and older readline Message-ID: <201404151917.s3FJHmYF028410@gromit.timing.com> Resent-Message-ID: <201404151920.s3FJK08b081433@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 188670 >Category: ports >Synopsis: [patch] update devel/seed (2.31.91) to build with both new and older readline >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Apr 15 19:20:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: John Hein >Release: >Organization: >Environment: System: >Description: If the devel/readline (6.3+) port is installed, you can get build errors with devel/seed (currently 2.31.91_4). gmake[3]: Entering directory `/d/pub/jhein/.no-amanda-backup/wd/usr/ports/devel/seed/work/seed-2.31.91/modules/readline' CC libseed_readline_la-seed-readline.lo seed-readline.c: In function 'seed_readline_bind': seed-readline.c:80: error: 'Function' undeclared (first use in this function) seed-readline.c:80: error: (Each undeclared identifier is reported only once seed-readline.c:80: error: for each function it appears in.) seed-readline.c:80: error: expected expression before ')' token >How-To-Repeat: install devel/readline (6.3.3) try to build devel/seed (2.31.91_4) >Fix: Index: devel/seed/files/patch-modules_readline_seed-readline.c =================================================================== --- devel/seed/files/patch-modules_readline_seed-readline.c (revision 0) +++ devel/seed/files/patch-modules_readline_seed-readline.c (working copy) @@ -0,0 +1,16 @@ +'Function' is deprecated - patch to work with older readline API +(e.g., currently in base) or new (e.g., readline 6.3.3 in ports). + +http://lists.gnu.org/archive/html/bug-readline/2014-03/msg00002.html + +--- modules/readline/seed-readline.c.orig 2010-08-30 15:37:39.000000000 -0600 ++++ modules/readline/seed-readline.c 2014-04-15 13:00:13.000000000 -0600 +@@ -77,7 +77,7 @@ + key = seed_value_to_string(ctx, arguments[0], exception); + c = seed_make_rl_closure((SeedObject) arguments[1]); + +- rl_bind_key(*key, (Function *) c); ++ rl_bind_key(*key, (rl_command_func_t *) c); + + g_free(key); + >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404151917.s3FJHmYF028410>