Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 May 2001 23:54:58 +0400
From:      Yar Tikhiy <yar@FreeBSD.ORG>
To:        Matthew Emmerton <matt@gsicomp.on.ca>
Cc:        alex <ml-freebsd-net@phobgate.de>, freebsd-net@FreeBSD.ORG
Subject:   Re: no free() after malloc() in arp (src/usr.sbin/arp/arp.c)
Message-ID:  <20010502235458.A45785@comp.chem.msu.su>
In-Reply-To: <015b01c0d1e9$2557a560$1200a8c0@gsicomp.on.ca>; from matt@gsicomp.on.ca on Mon, Apr 30, 2001 at 10:48:01PM -0400
References:  <824983177.988667461@[192.168.2.94]> <015b01c0d1e9$2557a560$1200a8c0@gsicomp.on.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 30, 2001 at 10:48:01PM -0400, Matthew Emmerton wrote:
> 
> > i don't see a security issue in this, just want to ask if this is ok (or
> > maybe unwanted?):
> >
> > in src/usr.sbin/arp/arp.c in function search() (starts line ~429) i see
> > this (line ~447):
> >
> >         if ((buf = malloc(needed)) == NULL)
> >
> > this allocated memory isn't free'd later in this function. so if arp uses
> > this function over and over again, memory fills up (not much, but it
> does).
> 
> This has been reported with a fix in PR bin/27001.
> http://www.freebsd.org/cgi/query-pr.cgi?pr=27001

Thanks, committed to -current.

-- 
Yar

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010502235458.A45785>