Date: Sun, 28 Oct 2001 08:50:00 +1030 From: Greg Lehey <grog@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: mjacob@feral.com, Jonathan Lemon <jlemon@flugsvamp.com>, "Andrey A. Chernov" <ache@nagual.pp.ru>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Causing known breakage (was: cvs commit: src/sys/kern kern_conf.c subr_disk.c) Message-ID: <20011028085000.O8085@wantadilla.lemis.com> In-Reply-To: <18358.1004208601@critter.freebsd.dk>; from phk@critter.freebsd.dk on Sat, Oct 27, 2001 at 08:50:01PM %2B0200 References: <20011027113537.A67553-100000@wonky.feral.com> <18358.1004208601@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, 27 October 2001 at 20:50:01 +0200, Poul-Henning Kamp wrote: > >>> The fact that the kernel has been whining about >>> WARNING: driver mistake... >>> all along wouldn't count as a HEADSUP would it ? >>> >>> It sure does to me... >> >> When you make a change that is likely to panic kernels for most people, it's a >> courtesy to waste 30 seconds of email time. > > If the kernel prints odd messages containing words like > "WARNING" "error", "mistake", "panic" and the name of your > device driver or other reference to your code, you can > safely ignore these messages as long as the system keeps > running. > > It probably just means that you misunderstood some boring > API or something, and you can rest assured that the committer > working with that API will visit you personally (or call > you on the phone inside business hours if you live more > than 3 continents away) and explain to you what he will do > to accomodate your use of the API. > > Should your kernel stop working because of such messages, > you are free to abuse, threathen and use any kind of > harrassment until somebody else fixes the problem in your > code. I can't be bothered looking for a rule that says you shouldn't commit anything which will knowingly cause breakage, but if it's not in the book, it should be. First ensure that cause of the breakage gets fixed, or fix it yourself. Greg -- See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011028085000.O8085>