Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Nov 2013 03:00:45 +0000 (UTC)
From:      Colin Percival <cperciva@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r257602 - user/cperciva/panicmail
Message-ID:  <201311040300.rA430jCQ066512@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cperciva
Date: Mon Nov  4 03:00:44 2013
New Revision: 257602
URL: http://svnweb.freebsd.org/changeset/base/257602

Log:
  Change
  	local tmpfile=`mktemp` || exit 1
  into
  	local tmpfile
  	tmpfile=`mktemp` || exit 1
  since the former is parsed as "local || exit 1" and loses the exit code
  from mktemp.
  
  Submitted by:	jilles

Modified:
  user/cperciva/panicmail/panicmail

Modified: user/cperciva/panicmail/panicmail
==============================================================================
--- user/cperciva/panicmail/panicmail	Mon Nov  4 02:58:16 2013	(r257601)
+++ user/cperciva/panicmail/panicmail	Mon Nov  4 03:00:44 2013	(r257602)
@@ -37,7 +37,8 @@ stop_cmd=":"
 # Gather the data we want to include in a panic report.
 panicmail_gather()
 {
-	local tmpfile=`mktemp` || exit 1
+	local tmpfile
+	tmpfile=`mktemp` || exit 1
 
 	# We want the dump header.
 	cat "${dumpdir}/info.$1" > "${dumpdir}/panicmail.$1"
@@ -59,7 +60,8 @@ panicmail_gather()
 # Encrypt the information in the panic report.
 panicmail_encrypt()
 {
-	local tmpfile=`mktemp` || exit 1
+	local tmpfile
+	tmpfile=`mktemp` || exit 1
 
 	# Encrypt using pkesh.
 	/usr/local/bin/pkesh enc "$2" "${dumpdir}/panicmail.$1" "${tmpfile}" || exit 1



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311040300.rA430jCQ066512>