Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 May 2013 09:06:23 +0200
From:      Pietro Cerutti <gahr@FreeBSD.org>
To:        Bryan Drewery <bdrewery@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r318659 - head/www/tdom/files
Message-ID:  <20130522070622.GA55046@gahrfit.gahr.ch>
In-Reply-To: <519BFFFA.1050705@FreeBSD.org>
References:  <201305210829.r4L8T5DS091115@svn.freebsd.org> <519BFFFA.1050705@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--lrZ03NoBR/3+SXJZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2013-May-21, 18:15, Bryan Drewery wrote:
> On 5/21/2013 3:29 AM, Pietro Cerutti wrote:
> > Author: gahr
> > Date: Tue May 21 08:29:04 2013
> > New Revision: 318659
> > URL: http://svnweb.freebsd.org/changeset/ports/318659
> >=20
> > Log:
> >   - Fix build with Tcl 8.6
> >  =20
> >   Reported by:	miwi (Tcl/Tk 86 exp-run)
> >   Approved by:	portmgr
> >=20
> > Added:
> >   head/www/tdom/files/patch-generic-tcldom.c   (contents, props changed)
> >=20
> > Added: head/www/tdom/files/patch-generic-tcldom.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/www/tdom/files/patch-generic-tcldom.c	Tue May 21 08:29:04 2013=
	(r318659)
> > @@ -0,0 +1,11 @@
> > +--- ../generic/tcldom.c.orig	2013-05-13 11:36:27.000000000 +0200
> > ++++ ../generic/tcldom.c	2013-05-13 11:39:00.000000000 +0200
> > +@@ -5934,7 +5934,7 @@
> > +     if (ret =3D=3D TCL_ERROR) {
> > +         char msg[64 + TCL_INTEGER_SPACE];
> > +         sprintf(msg, "\n    (\"%s %s\" body line %d)", Tcl_GetString(=
objv[0]),
> > +-                Tcl_GetString(objv[1]), interp->errorLine);
> > ++                Tcl_GetString(objv[1]), Tcl_GetErrorLine(interp));
> > +         Tcl_AddErrorInfo(interp, msg);
> > +     }
> > +=20
> >=20
>=20
> This seems to break WITH_TCL_VER=3D85:
>=20
> > /usr/bin/env LANG=3DC make -C /wrkdirs/usr/ports/www/tdom/work/tDOM-0.8=
=2E3/unix test
> > TCL_LIBRARY=3D`echo /wrkdirs/usr/ports/lang/tcl85/work/tcl8.5.14/librar=
y`  LD_LIBRARY_PATH=3D".:/usr/local/lib/tcl8.5:"  PATH=3D".:/usr/local/lib/=
tcl8.5:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/=
bin:/root/bin"  TCLLIBPATH=3D"." /usr/local/bin/tclsh8.5 `echo ./../tests/a=
ll.tcl` -constraints longRunning
> > couldn't load file "./libtdom0.8.3.so": ./libtdom0.8.3.so: Undefined sy=
mbol "Tcl_GetErrorLine"
> >     while executing
> > "load ./libtdom0.8.3.so"
> >     ("package ifneeded tdom 0.8.3" script)
> >     invoked from within
> > "package require -exact tdom 0.8.3"
> >     invoked from within
> > "if {[catch {package present -exact tdom 0.8.3}]} {
> >     package require -exact tdom 0.8.3
> > } else {
> >     if {[lsearch [namespace children] ::tDOM] =3D=3D -1}..."
> >     (file "./../tests/loadtdom.tcl" line 20)
> >     invoked from within
> > "source [file join [file dir [info script]] loadtdom.tcl]"
> >     (file "./../tests/all.tcl" line 12)
> > *** Error code 1
> >=20
> > Stop in /wrkdirs/usr/ports/www/tdom/work/tDOM-0.8.3/unix.
> > *** Error code 1

Fixed, thanks!

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--lrZ03NoBR/3+SXJZ
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlGcbm0ACgkQwMJqmJVx944hHgCg4c2Mwosw1OHOtQhfAh3Qw5ps
C9AAoKhzwpXGiRTfv512YTBl640ehA7T
=8DMc
-----END PGP SIGNATURE-----

--lrZ03NoBR/3+SXJZ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130522070622.GA55046>