Date: Fri, 21 Oct 2005 00:15:48 +0200 From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr> To: Tomas Verbaitis <tomasv@megalogika.lt> Cc: freebsd-java@freebsd.org Subject: Re: Tomcat 5.5 startup and shutdown.. again Message-ID: <20051020221548.GA3979@arabica.esil.univ-mrs.fr> In-Reply-To: <20051020175328.GA7205@megalogika.lt> References: <20051020175328.GA7205@megalogika.lt>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Tomas,
On Thu, Oct 20, 2005 at 08:53:28PM +0300, Tomas Verbaitis wrote:
> Having both tools available can create some mess: you can launch at
> least two copies of Tomcat using both tools, you can not stop Tomcat
> launched with rcNG script using tomcat55ctl and vice versa.
Indeed.
> Then i checked org.apache.catalina.startup.Catalina and found that it
> doesn't do anything spectacular at shutdown: it just calls stop(), which
> is also called when CatalinaShutdownHook() is run. Hence, i assume, it's
> equally safe to stop Tomcat by sending it a SIGTERM.
>
> This would also simplify rcNG script, as it could use default
> /etc/rc.subr functions.
That's a good idea IMHO.
Anyway, there seem to be a problem with your patch (although I have not
tested it yet).
> --- tomcat.sh.in.orig Wed Sep 14 15:30:23 2005
> +++ tomcat.sh.in Thu Oct 20 20:18:32 2005
> -procname="java"
> +procname="%%JAVA_HOME%%/bin/java"
[...]
> --- Makefile.orig Thu Sep 29 18:08:23 2005
> +++ Makefile Thu Oct 20 20:35:40 2005
> @@ -64,7 +64,8 @@
> + JAVA_HOME=${JAVA_HOME}
Here you define ${procname} to be hardcoded from a JAVA_HOME value in
the port. This JAVA_HOME is set at install time but the rcNG script
allows to override JAVA_HOME at run-time:
jakarta_tomcat%%TOMCAT_VERSION%%_java_home
What will happen if the JAVA_HOME from port install stage and the one
set in rc.conf are different?
> If port maintainers think it makes sense, i can file a PR, so this
> proposal does not get forgotten -- Herve promised not to touch tomcat55
> until other Tomcat ports are fixed, so it can take time :)
Well, I assume you refer to my last PR change-state. Actually I plan to
make sure that the refactored www/jakarta-tomcat55 port is in good shape
and that community had time to test it before we merge its improvements
into the other tomcat ports. I think we need to first fix the security
issues that Jan Grant pointed out. But if you can find a way to fix the
problem I outlined above and depending on the maintainer's approval
regarding this, I can commit this as well.
Herve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051020221548.GA3979>