Date: Sat, 7 Sep 2002 01:01:46 +0300 From: Maxim Sobolev <sobomax@FreeBSD.ORG> To: Peter Wemm <peter@wemm.org> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net if_gre.c if_gre.h src/sys/netinet ip_gre.c Message-ID: <20020906220146.GA2737@vega.vega.com> In-Reply-To: <20020906211015.A381C2A7D6@canning.wemm.org> References: <200209061816.g86IG3ni003518@freefall.freebsd.org> <20020906211015.A381C2A7D6@canning.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 06, 2002 at 02:10:15PM -0700, Peter Wemm wrote: > Maxim Sobolev wrote: > > sobomax 2002/09/06 11:16:03 PDT > > > > Modified files: > > sys/net if_gre.c if_gre.h > > sys/netinet ip_gre.c > > Log: > > Reduce namespace pollution by staticizing everything, which doesn't need to > > be visible from outside of the module. > > This seems to break kdump: > > ===> usr.bin/kdump > cc -O -pipe -I/home/src/usr.bin/kdump/../ktrace -I/home/src/usr.bin/kdump/../.. -c /home/src/usr.bin/kdump/kdump.c > cc -O -pipe -I/home/src/usr.bin/kdump/../ktrace -I/home/src/usr.bin/kdump/../.. -c ioctl.c > In file included from ioctl.c:63: > /usr/obj/home/src/i386/usr/include/net/if_gre.h:89: field `gi_i' has incomplete type > /usr/obj/home/src/i386/usr/include/net/if_gre.h:133: field `mi' has incomplete type Hmm, I suspect that actually broken is mkioctls, which have absolutely no reason to generate #include <net/if_gre.h>. In any case, I've committed a fix which should workaround the problem. Please let me know if it didn't help. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020906220146.GA2737>