Date: Mon, 3 Aug 2009 11:04:31 -0400 From: "David Boyd" <David.Boyd@insightbb.com> To: <freebsd-current@freebsd.org> Cc: freebsd-stable@freebsd.org Subject: FW: 8.0-BETA2 sysinstall ignoring setting of nonInteractive Message-ID: <OJEBKOFDEOADELCOBJCGEEMECEAA.David.Boyd@insightbb.com>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
------=_NextPart_000_0102_01CA142A.2D81BE60
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Can someone "PLEASE" commit this fix.
Daniel was kind enough to write it up, but it has not been committed as of
8/3/2009.
Thanks.
-----Original Message-----
From: Daniel O'Connor [mailto:doconnor@gsoft.com.au]
Sent: Tuesday, July 21, 2009 8:28 PM
To: freebsd-current@freebsd.org
Cc: David Boyd
Subject: Re: 8.0-BETA2 sysinstall ignoring setting of nonInteractive
On Wed, 22 Jul 2009, David Boyd wrote:
> With 8.0-BETA(1/2) sysinstall ignores setting of nonInteractive
> variable when using USB-based install.
>
> With or without nonInteractive sysinstall issues message "Using USB
> device: da0a" and waits for confirmation.
>
> This breaks unattended installations using USB device.
I think this would fix it, can you test it?
Index: media.c
===================================================================
--- media.c (revision 195813)
+++ media.c (working copy)
@@ -262,7 +262,8 @@
mediaDevice = devs[0];
if (mediaDevice)
mediaDevice->private = NULL;
- msgConfirm("Using USB device: %s", mediaDevice->name);
+ if (!variable_get(VAR_NONINTERACTIVE))
+ msgConfirm("Using USB device: %s", mediaDevice->name);
return (mediaDevice ? DITEM_LEAVE_MENU : DITEM_FAILURE);
}
--
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
"The nice thing about standards is that there
are so many of them to choose from."
-- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
------=_NextPart_000_0102_01CA142A.2D81BE60
Content-Type: application/pgp-signature;
name="signature.asc"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)
iD8DBQBKZl0N5ZPcIHs/zowRAoLJAJ9g6jj7/mBUj4NR3SMfh+3MV1g3fACfVZme
1YXKwM71isOudr84BUtk698=
=1V92
-----END PGP SIGNATURE-----
------=_NextPart_000_0102_01CA142A.2D81BE60--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?OJEBKOFDEOADELCOBJCGEEMECEAA.David.Boyd>