Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 01 Jun 2004 10:32:31 +0200
From:      Oliver Eikemeier <eikemeier@fillmore-labs.com>
To:        Roman Neuhauser <neuhauser@chello.cz>
Cc:        Kirill Ponomarew <krion@voodoo.oberon.net>
Subject:   Re: respect CFLAGS: should I override optimizations?
Message-ID:  <40BC3F1F.8080207@fillmore-labs.com>
In-Reply-To: <20040601082203.GA17296@isis.wad.cz>
References:  <20040531233106.GE85902@isis.wad.cz> <20040601074657.GF34332@voodoo.oberon.net> <20040601082203.GA17296@isis.wad.cz>

next in thread | previous in thread | raw e-mail | index | archive | help
Roman Neuhauser wrote:
> [...]
> 
>>Porters Handbook expresses clearly:
>>
>>"The port should respect the CFLAGS variable. What we mean by
>>this is that the port should not set the value of this variable
>>absolutely, overriding the existing value; instead, it should
>>append whatever values it needs to the existing value. This is
                            ^^^^^
>>so that build options that affect all ports can be set
>>globally."
> 
>     Yes, that's *very clear*, and means that I should turn the
> 
>     CFLAGS = -O3 -Wall ...
> 
>     to 
> 
>     CFLAGS += -O3 -Wall ...

It depends whether you consider `-O3' to be needed by the port.
Does it compile and run without?

-Oliver



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40BC3F1F.8080207>