Date: Mon, 24 Oct 2011 17:42:28 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226687 - head/sys/fs/nullfs Message-ID: <20111024144228.GL50300@deviant.kiev.zoral.com.ua> In-Reply-To: <20111024142245.GA73120@freebsd.org> References: <201110241353.p9ODrW99046445@svn.freebsd.org> <20111024142245.GA73120@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dYbRCasfhpyZLUd7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 24, 2011 at 04:22:45PM +0200, Roman Divacky wrote: > On Mon, Oct 24, 2011 at 01:53:32PM +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Mon Oct 24 13:53:32 2011 > > New Revision: 226687 > > URL: http://svn.freebsd.org/changeset/base/226687 > >=20 > > Log: > > The only possible error return from null_nodeget() is due to insmntqu= e1 > > failure (the getnewvnode cannot return an error). In this case, the > > null_insmntque_dtr() already unlocked the reclaimed vnode, so VOP_UNL= OCK() > > in the nullfs_mount() after null_nodeget() failure is wrong. > > =20 > > Tested by: pho > > MFC after: 1 week > >=20 > > Modified: > > head/sys/fs/nullfs/null_vfsops.c > >=20 > > Modified: head/sys/fs/nullfs/null_vfsops.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/fs/nullfs/null_vfsops.c Mon Oct 24 13:48:13 2011 (r226686) > > +++ head/sys/fs/nullfs/null_vfsops.c Mon Oct 24 13:53:32 2011 (r226687) > > @@ -157,7 +157,6 @@ nullfs_mount(struct mount *mp) > > * Make sure the node alias worked > > */ > > if (error) { > > - VOP_UNLOCK(vp, 0); >=20 > Maybe you want to assert that it's indeed unlocked at this point? No, I don't, since the vnode pointer is already invalid at this point. The vput() call in dtr released the vnode reference owned by current thread. --dYbRCasfhpyZLUd7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk6leVQACgkQC3+MBN1Mb4ibCwCfRusCwPjeHfURw4eduKBaKgkR E7sAoLjo+IQl7ju/dSeagnxYoxzk35A/ =rR/d -----END PGP SIGNATURE----- --dYbRCasfhpyZLUd7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111024144228.GL50300>