Date: Wed, 27 May 2009 20:03:57 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: rea-fbsd@codelabs.ru Cc: freebsd-hackers@freebsd.org, Jakub Lach <jakub_lach@mailplus.pl> Subject: Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file symlink) vulnerability Message-ID: <86ab4yifsi.fsf@ds4.des.no> In-Reply-To: <U0NhVtBGTmaNGU7BFYREWm3L/jc@al5XJ3LyQHdj2bEPlOOCMqn3f1Q> (Eygene Ryabinkin's message of "Wed, 27 May 2009 21:28:49 %2B0400") References: <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no> <0vGjPHEq7MqxjtFmBufY%2BmBxlR4@7oUjtCwN654QcDr16CH%2BkAk8bJg> <86vdnmiz30.fsf@ds4.des.no> <15QQC%2B1YeDzOjf35dqyJmioc1ik@XX1fo6zQUfC4h0jjRC6IBz3oNH4> <86prdug1p0.fsf@ds4.des.no> <nhZ4ZNM2NtGGBpfrd4LGzlLPCPs@10Ilc7MfiXA2JVIRVQpZfk7cTQ4> <86vdnmijgs.fsf@ds4.des.no> <U0NhVtBGTmaNGU7BFYREWm3L/jc@al5XJ3LyQHdj2bEPlOOCMqn3f1Q>
next in thread | previous in thread | raw e-mail | index | archive | help
Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes: > 'if ()' looks suspicious: ISLASTCN is set some lines below so it could > be not yet flagged. Seems like we could omit 'if ()' clause but leave > it's body for the current state of the code -- it will be equivalent to > the mine's check. Yes, I was a little too quick there. You're right, we can just drop the if(). Actually, the reason why I moved this up is that I was considering eliminating the trailing_slash variable entirely. > By the way, I had somewhat extended your regression tests with the > intermediate symlink tests, directory tests and device-as-a-target > tests. Patches are attached. Will they go? I'll take a look at them later. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ab4yifsi.fsf>