Date: Thu, 21 Aug 2008 19:27:49 GMT From: Ed Schouten <ed@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 148033 for review Message-ID: <200808211927.m7LJRn1f093303@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=148033 Change 148033 by ed@ed_flippo on 2008/08/21 19:27:10 Small style(9) nits. Affected files ... .. //depot/projects/mpsafetty/sys/kern/tty.c#28 edit Differences ... ==== //depot/projects/mpsafetty/sys/kern/tty.c#28 (text+ko) ==== @@ -1681,19 +1681,18 @@ struct cdevsw *cdp; int error; - /* Validate the file descriptor */ + /* Validate the file descriptor. */ if (fget(td, fd, &fp) != 0) return (EINVAL); - /* Make sure the vnode is bound to a character device */ + /* Make sure the vnode is bound to a character device. */ error = EINVAL; if (fp->f_type != DTYPE_VNODE || fp->f_vnode->v_type != VCHR || - fp->f_vnode->v_rdev == NULL) { + fp->f_vnode->v_rdev == NULL) goto done1; - } dev = fp->f_vnode->v_rdev; - /* Make sure it is a TTY */ + /* Make sure it is a TTY. */ cdp = dev_refthread(dev); if (cdp == NULL) goto done1; @@ -1701,7 +1700,7 @@ goto done2; tp = dev->si_drv1; - /* Try to attach the hook to the TTY */ + /* Try to attach the hook to the TTY. */ error = EBUSY; tty_lock(tp); MPASS((tp->t_hook == NULL) == ((tp->t_flags & TF_HOOK) == 0)); @@ -1727,11 +1726,11 @@ tty_lock_assert(tp, MA_OWNED); MPASS(tp->t_flags & TF_HOOK); - /* Disconnect the hook */ + /* Disconnect the hook. */ tp->t_flags &= ~TF_HOOK; tp->t_hook = NULL; - /* Maybe deallocate the TTY as well */ + /* Maybe deallocate the TTY as well. */ tty_rel_free(tp); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808211927.m7LJRn1f093303>