Date: Sat, 20 Sep 2008 12:58:17 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 150166 for review Message-ID: <200809201258.m8KCwHXw008362@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=150166 Change 150166 by hselasky@hselasky_laptop001 on 2008/09/20 12:58:11 Fix incorrect locking. The code path where the incorrect locking exists is currently not used. Affected files ... .. //depot/projects/usb/src/sys/dev/usb2/core/usb2_busdma.c#6 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_busdma.c#6 (text+ko) ==== @@ -614,7 +614,6 @@ /* * Try to load memory into DMA. */ - mtx_lock(uptag->mtx); err = bus_dmamap_load( pc->tag, pc->map, pc->buffer, size, &usb2_pc_alloc_mem_cb, pc, BUS_DMA_WAITOK); @@ -622,8 +621,6 @@ usb2_cv_wait(uptag->cv, uptag->mtx); err = 0; } - mtx_unlock(uptag->mtx); - if (err || uptag->dma_error) { return (1); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200809201258.m8KCwHXw008362>