Date: Sun, 16 Dec 2007 21:34:15 -0800 From: Sam Leffler <sam@errno.com> To: Kip Macy <kmacy@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet if_ether.c Message-ID: <47660A57.8060108@errno.com> In-Reply-To: <200712170419.lBH4JPJg026761@repoman.freebsd.org> References: <200712170419.lBH4JPJg026761@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kip Macy wrote:
> kmacy 2007-12-17 04:19:25 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/netinet if_ether.c
> Log:
> Don't panic in arpresolve if we're given a null mbuf. We could
> insist that the caller just pass in an initialized mbuf even
> if didn't have any data - but that seems rather contrived.
>
You don't explain the purpose of this change. arpresolve has been
designed for use in the xmit path where there is always an mbuf. This
feels like you are now applying it for a different purpose and it might
be better to define a different api than overload arpresolve's intended
purpose.
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47660A57.8060108>