Date: Mon, 10 Oct 2005 11:06:49 +0200 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.org> To: Peter Edwards <peadar@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c Message-ID: <D29978F6-7AD7-4EF8-8A7F-12F7EE533845@FreeBSD.org> In-Reply-To: <200510092111.j99LB5gN037609@repoman.freebsd.org> References: <200510092111.j99LB5gN037609@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/10/2005, at 23:11, Peter Edwards wrote: Why did you ask me to review this when you just committed it anyway ? As I said I'm not sure this is the right way to fix this.. So, this means *you* are now the maintainer of atapi-cd,c ?! -S=F8ren > peadar 2005-10-09 21:11:05 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata atapi-cd.c > Log: > When breaking up a large request into smaller ones for the strategy > routine, create all the child bio objects before starting the > requests, rather than starting them as created. This closes a race > whereby some number of child operations could complete before the > rest were ever created, and prematurely freeing the parent bio. > This fixes the panics installing in VMWare and qemu > > Revision Changes Path > 1.181 +7 -1 src/sys/dev/ata/atapi-cd.c > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D29978F6-7AD7-4EF8-8A7F-12F7EE533845>