Date: Sat, 22 Dec 2001 17:13:45 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: <babkin@freebsd.org> Cc: Erik Trulsson <ertr1013@student.uu.se>, Steve Price <steve@freebsd.org>, Andreas Klemm <andreas@freebsd.org>, <cvs-committers@freebsd.org>, <cvs-all@freebsd.org> Subject: Re: sh patch Re: cvs commit: ports/print/apsfilter Makefile ports/print/apsfilter/files patch-bin::aps2file ports/print/apsfilter/scriptspre-configure Message-ID: <20011222164918.Q7048-100000@gamplex.bde.org> In-Reply-To: <3C23CBE8.D7DDEE80@bellatlantic.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Dec 2001, Sergey Babkin wrote: > Bruce Evans wrote: > > This seems to introduce a race by moving the close after the INTON. > > That seems to be OK: in popredir() it first closes the old > descriptor then moves the saved descriptor to the new descriptor, > in clearredir() it just closes the saved descriptors and leaves > the old descriptors alone. My understanding is that INTOFF and Yes, this might work because there are only leak possibilities for descriptors 0..9 and popredir() closes these almost unconditionally. The symptoms of brokenness would be redirects failing, not fd leaks, since the shell only uses small fd's (0..10 only?). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011222164918.Q7048-100000>