Date: Thu, 21 Aug 2008 21:32:02 GMT From: Ed Schouten <ed@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 148049 for review Message-ID: <200808212132.m7LLW2B7023537@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=148049 Change 148049 by ed@ed_flippo on 2008/08/21 21:31:23 D'oh! Don't forget to check the return value of ttyhook_register() in SNPSTTY. Affected files ... .. //depot/projects/mpsafetty/sys/dev/snp/snp.c#9 edit Differences ... ==== //depot/projects/mpsafetty/sys/dev/snp/snp.c#9 (text+ko) ==== @@ -243,6 +243,8 @@ error = ttyhook_register(&ss->snp_tty, td, *(int *)data, &snp_hook, ss); sx_xunlock(&snp_register_lock); + if (error != 0) + return (error); /* Now that went okay, allocate a buffer for the queue. */ tp = ss->snp_tty; @@ -250,7 +252,7 @@ ttyoutq_setsize(&ss->snp_outq, tp, SNP_OUTPUT_BUFSIZE); tty_unlock(tp); - return (error); + return (0); case SNPGTTY: /* Obtain device number of associated TTY. */ if (ss->snp_tty == NULL)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808212132.m7LLW2B7023537>