Date: Wed, 19 Oct 2011 12:30:39 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: Ryan Stone <rysto32@gmail.com> Cc: freebsd-net <freebsd-net@freebsd.org>, Rozhuk.IM@gmail.com Subject: Re: ether_demux does not handle frames with embedded vlan tags Message-ID: <CACVs6=_6gHDay96a=pSw6Un_6fh=fuAew=DWYvWokBnyA=Y7Lg@mail.gmail.com> In-Reply-To: <CAFMmRNxoJafz9kz66sQXVYcsvd-tr8wqkh_-BbfhHD8RqRygKA@mail.gmail.com> References: <CAFMmRNz2Gqmk7wmiA83eQZfR9Rkcro9seD5ORYRHxKhZV%2BaR9Q@mail.gmail.com> <4e9e0de3.4364cc0a.38b5.ffffc94f@mx.google.com> <CAFMmRNxMPh9SOwXHR8uWqNMR=ns5HfFzb2OiB=wC2Kn%2B61PKbQ@mail.gmail.com> <4e9e6ba6.c972cd0a.3d45.ffffd504@mx.google.com> <CAFMmRNxoJafz9kz66sQXVYcsvd-tr8wqkh_-BbfhHD8RqRygKA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 19, 2011 at 07:36, Ryan Stone <rysto32@gmail.com> wrote: > 2011/10/19 =C2=A0<rozhuk.im@gmail.com>: >> This may be a wrong configuration or QinQ: packet may have M_VLAN tag is >> set and still vlan-tagged (ether_type =3D VLAN) > > It is not QinQ in my case. =C2=A0The interface that the upper hook export= s > is that you send it a valid ethernet frame and it passes that frame up > the stack. =C2=A0A vlan-tagged frame is a valid frame so I don't see why = it > should not be handled correctly. Why should the requirements for the Netgraph path be any different to the non-Netgraph path? If drivers must ensure that frames that reach ether_demux have had their VLAN tags stripped, so should Netgraph things that act like drivers. So why don't you move that logic into ether_demux from the ether_input path, or have Netgraph use the ether_input path?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACVs6=_6gHDay96a=pSw6Un_6fh=fuAew=DWYvWokBnyA=Y7Lg>