Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Apr 2016 05:13:36 +0000 (UTC)
From:      "Conrad E. Meyer" <cem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r298340 - head/sys/dev/sym
Message-ID:  <201604200513.u3K5DaSg097934@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cem
Date: Wed Apr 20 05:13:36 2016
New Revision: 298340
URL: https://svnweb.freebsd.org/changeset/base/298340

Log:
  sym(4): Don't double-free 'sim' in failure case
  
  Reported by:	Coverity
  CID:		1006106
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/sys/dev/sym/sym_hipd.c

Modified: head/sys/dev/sym/sym_hipd.c
==============================================================================
--- head/sys/dev/sym/sym_hipd.c	Wed Apr 20 05:11:00 2016	(r298339)
+++ head/sys/dev/sym/sym_hipd.c	Wed Apr 20 05:13:36 2016	(r298340)
@@ -8890,6 +8890,7 @@ static int sym_cam_attach(hcb_p np)
 	if (xpt_bus_register(sim, np->device, 0) != CAM_SUCCESS)
 		goto fail;
 	np->sim = sim;
+	sim = NULL;
 
 	if (xpt_create_path(&path, NULL,
 			    cam_sim_path(np->sim), CAM_TARGET_WILDCARD,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604200513.u3K5DaSg097934>