Date: Tue, 08 May 2001 00:55:51 +0100 From: Brian Somers <brian@Awfulhak.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Brian Somers <brian@FreeBSD.org>, brian@Awfulhak.org Subject: Re: cvs commit: src/sys/dev/digi digi.c digi.h digi_isa.c digi_p Message-ID: <200105072355.f47NtpB14404@hak.lan.Awfulhak.org> In-Reply-To: Message from John Baldwin <jhb@FreeBSD.org> of "Mon, 07 May 2001 08:43:40 PDT." <XFMail.010507084340.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 07-May-01 John Baldwin wrote: > > > > On 07-May-01 Brian Somers wrote: > >> brian 2001/05/07 04:13:13 PDT > >> > >> Modified files: > >> sys/dev/digi digi.c digi.h digi_isa.c digi_pci.c > >> Log: > >> Change COM_LOCK/COM_UNLOCK to a regular mutex - still conditional on > >> SMP being defined. > > > > Woah. COM_LOCK is a special case due to sio/cy using fast interrupt > > handlers, > > and if digi is using a fast interrupt handler, then it needs to be a spin > > mutex, not a regular mutex. Also, mutexes should be on all the time, not > > just > >#ifdef SMP. Note that COM_LOCK is always defined now. > > Well, having checked the code, it seems you don't use fast interrupt handlers, > so you didn't need COM_LOCK to begin with and you don't need the mutex you are > using right now. tty drivers won't be locked until the tty subsystem is locked > and we figure out how we are going to lock tty data structures. So should I just pull out the mutex stuff for now ? > -- > > John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ > PGP Key: http://www.baldwin.cx/~john/pgpkey.asc > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ -- Brian <brian@Awfulhak.org> <brian@[uk.]FreeBSD.org> <http://www.Awfulhak.org>; <brian@[uk.]OpenBSD.org> Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105072355.f47NtpB14404>