Date: Thu, 21 May 2015 13:03:35 -0700 From: Hiren Panchasara <hiren@freebsd.org> To: Lawrence Stewart <lstewart@freebsd.org> Cc: Eric van Gyzen <vangyzen@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283136 - head/sys/netinet Message-ID: <20150521200335.GG95600@strugglingcoder.info> In-Reply-To: <555CC40C.1070502@freebsd.org> References: <201505200108.t4K181No006311@svn.freebsd.org> <555C09D5.9090709@freebsd.org> <20150520042438.GA95600@strugglingcoder.info> <555C2ABC.60102@freebsd.org> <555C89F4.9080607@FreeBSD.org> <555CC40C.1070502@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Qf1oXS95uex85X0R Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05/21/15 at 03:27P, Lawrence Stewart wrote: > On 05/20/15 23:19, Eric van Gyzen wrote: > > On 05/20/2015 02:33, Lawrence Stewart wrote: > >> On 05/20/15 14:24, Hiren Panchasara wrote: > >>> On 05/20/15 at 02:13P, Lawrence Stewart wrote: > >>>> Hi Hiren, > >>>> > >>>> On 05/20/15 11:08, Hiren Panchasara wrote: > >>>>> Author: hiren Date: Wed May 20 01:08:01 2015 New Revision: > >>>>> 283136 URL: https://svnweb.freebsd.org/changeset/base/283136 > >>>>> > >>>>> Log: Add a new sysctl net.inet.tcp.hostcache.purgenow=3D1 to > >>>>> expire and purge all entries in hostcache immediately. > >>>>> > >>>>> In collaboration with: bz, rwatson MFC after: 1 week Relnotes: > >>>>> yes Sponsored by: Limelight Networks > >>>> > >>>> Why introduce a new sysctl and not change the existing behaviour > >>>> of net.inet.tcp.hostcache.purge? > >>> > >>> I thought it'd make more sense to keep the existing behavior as is > >>> and provide new knob for the new behavior. > >> > >> Don't think so - why would deferring a purge to the next purge run be > >> useful compared to purging immediately? I'd strongly suggest you adapt > >> this change to the existing purge sysctl. I can't see why anyone would > >> miss the old functionality. > >=20 > > I am generally wary of a question such as "Why would anyone want...", b= ecause as soon as the code is released, someone answers it. > >=20 > > That being said, I have always wanted Hiren's purgenow behavior, and I'= ve always been annoyed by the lazy-purge behavior. I would suggest impleme= nting Lawrence's suggestion, but NOT MFC'ing it, since that would be a disr= uptive change. > >=20 > > Thanks for your work, Hiren. >=20 > I see no reason not to MFC it - it's not a POLA violation for a stable > branch. When the user requests a purge, it's surely equally as good (and > I think anyone of right mind would argue better ;) to purge immediately > than some number of seconds "n" in the future, where "n" is between 1 > and the value of net.inet.tcp.hostcache.prune. I *do* want to MFC the change. And if there are no major objections, I'll go ahead with what Lawrence is suggesting: changing current purge behavior in = -head and 10. cheers, Hiren --Qf1oXS95uex85X0R Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVXjoWXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/l7gYH/1ayiXe7gEQ1izVPB5xvwKCb ESr8lv/KUeN2AktCi7Q3tjdvb9pPlygZRlXSrlgrw20fzpOYg79xRxuBIk0wEqg9 g90TdbCE0m3oTCREDGzNFgL5h4Mc0hRATHV4qplEFwIgpdKNQCtK5BEbNOtqGRAV jPwj7AmpCm8etkBTmr0dBXaIA4mRGG005whHOh4SUFs5upwiW34IRP6na+bcmwOb DOwxJkp92lA7bWPEmKXJdpb6UZi93WIOtdUVntPZsxj41YVejw+BGxJkxchnv3eT BKEUm+mpH4xJ8o7bOfpABBRSU+wNgwnkPD4B3H14dvv3/XQgy+rh1N2v63ST9pE= =HR4I -----END PGP SIGNATURE----- --Qf1oXS95uex85X0R--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150521200335.GG95600>