Date: Tue, 03 Sep 2013 06:38:12 -0500 From: Mark Felder <feld@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r325891 - in head/dns/rbldnsd: . files Message-ID: <1378208292.31958.17293657.7A5FBE25@webmail.messagingengine.com> In-Reply-To: <20130902014108.GE43972@FreeBSD.org> References: <201309011728.r81HSx4Z057688@svn.freebsd.org> <20130902014108.GE43972@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 1, 2013, at 20:41, Alexey Dokuchaev wrote: > On Sun, Sep 01, 2013 at 05:28:59PM +0000, Mark Felder wrote: > > New Revision: 325891 > > URL: http://svnweb.freebsd.org/changeset/ports/325891 > > > > @@ -37,6 +23,8 @@ GROUPS= ${USERS} > > PKGMESSAGE= ${WRKDIR}/pkg-message > > SUB_FILES= pkg-message > > > > +.include <bsd.port.pre.mk> > > + > > Any reason not to use <bsd.port.options.mk> instead? > I have no idea. I've never seen any documentation explaining the intricacies of bsd.port.options.mk and bsd.port.mk vs bsd.port.pre/post.mk. If it works, I just run with it. > > do-install: > > @if [ ! -d ${ROOTDIR} ]; then \ > > ${MKDIR} ${ROOTDIR}; \ > > @@ -47,7 +35,7 @@ do-install: > > ${FILESDIR}/example ${PREFIX}/etc/rbldnsd/ > > @${INSTALL_PROGRAM} ${WRKSRC}/rbldnsd ${PREFIX}/sbin/ > > @${INSTALL_MAN} ${WRKSRC}/rbldnsd.8 ${PREFIX}/man/man8/ > > The whole do-install recipe is badly indented (extra tabstop); > destination > paths carry bogus slashes at EOL, manpages should be installed relative > to > MAN[n]PREFIX (where optional n is section number). > > > -.if !defined(NOPORTDOCS) > > +.if ${PORT_OPTIONS:MDOCS} > > @${MKDIR} ${DOCSDIR}/ > > @${INSTALL_DATA} ${WRKSRC}/CHANGES-0.81 ${DOCSDIR} > > @${INSTALL_DATA} ${WRKSRC}/TODO ${DOCSDIR} > > @@ -57,7 +45,6 @@ do-install: > > @${INSTALL_DATA} ${WRKSRC}/debian/rbldnsd.default ${DOCSDIR} > > @${INSTALL_DATA} ${WRKSRC}/debian/rbldnsd.init ${DOCSDIR} > > @${INSTALL_DATA} ${WRKSRC}/rbldnsd.spec ${DOCSDIR} > > - @${INSTALL_DATA} ${DISTDIR}/rbldnsd.html ${DOCSDIR} > > We do not mute installation commands (muting MKDIR is fine). Silent > build > log does help to debug any potential problems. > Another three items that portlint should be picking up > > .endif > > > > -.include <bsd.port.mk> > > +.include <bsd.port.post.mk> > > Using <bsd.port.options.mk> above would have allow you to avoid changing > this line. > > > --- head/dns/rbldnsd/pkg-plist Sun Sep 1 17:28:00 2013 (r325890) > > +++ head/dns/rbldnsd/pkg-plist Sun Sep 1 17:28:59 2013 (r325891) > > @@ -8,6 +8,5 @@ etc/rbldnsd/example > > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.default > > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.init > > %%PORTDOCS%%%%DOCSDIR%%/rbldnsd.spec > > -%%PORTDOCS%%%%DOCSDIR%%/rbldnsd.html > > %%PORTDOCS%%@dirrm %%DOCSDIR%% > > @dirrmtry etc/rbldnsd/ > > Superfluous slash at EOL. > And a fourth. Where do I file bug reports against portlint? This was a simple maintainer update. I run this software in production at work, so I know the port is fully functional as-is. These changes are all style except possibly the bsd.*.mk stuff you've suggested. If we're going to clean up the entire ports tree we either need better tools to detect some of these issues or we need to start throwing errors when things aren't perfect. And thanks for pointing these things out -- I just simply took the maintainer's patch, applied, and fixed the messy rc script. It passed rclint/portlint, redports, and I was able to upgrade our production rbldnsd servers, so I didn't scrutinize the port further.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1378208292.31958.17293657.7A5FBE25>