Date: Tue, 31 Oct 2006 19:19:06 +0100 From: Erwin Lansing <erwin@FreeBSD.org> To: freebsd-ports@freebsd.org Subject: Re: How to make minor changes Message-ID: <20061031181905.GS80328@droso.net> In-Reply-To: <E0FF021CC6B63120C8C35D09@utd59514.utdallas.edu> References: <E0FF021CC6B63120C8C35D09@utd59514.utdallas.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--tn/dP4bPCRmapcqv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 31, 2006 at 12:04:34PM -0600, Paul Schmehl wrote: > I have two ports that were recently accepted into the tree. *After* they= =20 > were accepted, someone involved with the project asked me to make the=20 > following changes to the Makefiles: >=20 > I noticed that both sguil-server and sguil-sensor have this in the Makefi= le: >=20 > $ grep -i squil * > Makefile:COMMENT=3D Squil is a network security management program >=20 > Could you change that to >=20 > Makefile:COMMENT=3D Sguil is a network security monitoring program >=20 > If I submit PRs for this, do I have to set PORTREVISION to 1? Or does it= =20 > matter for such a minor change? >=20 Hi Paul, Please send all changes as a PR with a unified diff. That might seem a bit overkill for such a minor change, but it's the easiest way for committers to keep track of any request. Bumping PORTREVISION will force all users that already have this port installed to upgrade. So the general rule is, does this change affect them? Rewording the COMMENT is not enough reason for all users to upgrade, so it's better to leave it alone. Cheers, -erwin --=20 Erwin Lansing http://droso.org Security is like an onion. (o_ _o) It's made up of several layers \\\_\ /_/// erwin@FreeBSD.org And it makes you cry. <____) (____> erwin@aauug.dk --tn/dP4bPCRmapcqv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFR5OZqy9aWxUlaZARAl++AKCDsZtwnm9HiPXNXSUbtSkSsgNndwCfbocE yFz9uPGBbTILeFfGvhVSL6E= =iLKG -----END PGP SIGNATURE----- --tn/dP4bPCRmapcqv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061031181905.GS80328>