Date: Sun, 1 Sep 2013 08:23:19 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Sahil Tandon <sahil@tandon.net> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Anton Berezin <tobez@FreeBSD.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r325805 - head/Mk Message-ID: <CBB2F5EB-78BE-492A-AAFD-7D640600D91C@FreeBSD.org> In-Reply-To: <20130901130709.GA55745@jubz> References: <201308311322.r7VDM2wa076581@svn.freebsd.org> <20130831215840.GA13875@magnus> <20130901105928.GG26604@heechee.tobez.org> <20130901130709.GA55745@jubz>
next in thread | previous in thread | raw e-mail | index | archive | help
Looking now Sent from my iPhone On Sep 1, 2013, at 8:07, Sahil Tandon <sahil@tandon.net> wrote: > On Sun, 2013-09-01 at 12:59:28 +0200, Anton Berezin wrote: > [ .. ] >>> =3D> Attempting to fetch >>> ftp://ftp.porcupine.org/mirrors/postfix-release/experimental/postfix-2.= 11-20130825.tar.gz >>> postfix-2.11-20130825.tar.gz 100% of 3866 kB 910 >>> kBps >>> [: -eq: argument expected >>> =3D> Fetched file size mismatch (expected , actual 3959547) >>> =3D> Trying next site >>>=20 >>> This only happens if the distfile does not already exist (and therefore >>> needs to be fetched), and I 'make makesum'. Apparently, CKSIZE is >>> undefined. Notably, if I 'make fetch' first, and then 'make makesum', >>> there is no problem. >>=20 >> I see the same behavior. So, updating ports is kinda broken at the momen= t. >=20 > Looking at this a bit more, and I believe it happens because the makesum > target calls the fetch target with DISABLE_SIZE=3Dyes, and earlier in > bsd.port.mk, we have: >=20 > .if !defined(DISABLE_SIZE) > FETCH_BEFORE_ARGS+=3D $${CKSIZE:+-S $$CKSIZE} > .endif >=20 > Because CKSIZE is undefined, the following comparison inside the fetch > target does not work as intended: >=20 > if [ $${actual_size} -eq $${CKSIZE} ]; then \ >=20 > Hope this helps. >=20 > --=20 > Sahil Tandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CBB2F5EB-78BE-492A-AAFD-7D640600D91C>