Date: Fri, 18 Jan 2013 20:19:25 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r245610 - head/bin/ps Message-ID: <50F9F49D.5040000@FreeBSD.org> In-Reply-To: <50F9E354.1070709@FreeBSD.org> References: <201301181824.r0IIOfxd094865@svn.freebsd.org> <20130119112953.7a9aa66e@fubar.geek.nz> <50F9E354.1070709@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/18/13 7:05 PM, John Baldwin wrote: > On 1/18/13 5:29 PM, Andrew Turner wrote: >> On Fri, 18 Jan 2013 18:24:41 +0000 (UTC) >> John Baldwin <jhb@FreeBSD.org> wrote: >> >>> Author: jhb >>> Date: Fri Jan 18 18:24:40 2013 >>> New Revision: 245610 >>> URL: http://svnweb.freebsd.org/changeset/base/245610 >>> >>> Log: >>> Include the thread name along with the command name when displaying >>> the command name of a thread from a multi-threaded process that >>> doesn't have an available argument list (such as kernel processes) >>> and threads display is enabled via -H. >>> >>> Reviewed by: alfred, delphij, eric@vangyzen.net >>> MFC after: 1 week >> >> This breaks usr.bin/w as it includes bin/ps/fmt.c in it's build but >> doesn't have the showthreads variable defined. > > Ugh. It requires a bit more fixing than that even since w uses > fmt_argv() directly (and it had a stale prototype to boot). I have > a fix to get both ps and w to build but am waiting for a full world > to finish first in case some other place (ab)uses this. This should be fixed, sorry for the breakage. :( -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50F9F49D.5040000>