Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Feb 2003 12:57:42 -0800
From:      Will Andrews <will@csociety.org>
To:        Maxim Sobolev <sobomax@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/sysinstall index.c
Message-ID:  <20030227205742.GT37397@procyon.firepipe.net>
In-Reply-To: <200302272043.h1RKhq9f048530@repoman.freebsd.org>
References:  <200302272043.h1RKhq9f048530@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 27, 2003 at 12:43:52PM -0800, Maxim Sobolev wrote:
>   Log:
>   Increase size of the static buffer used to hold runtime dependency list
>   read from CD from 2k to 16k, because in the modern world of meta-packages
>   (Gnome et al) the length of this list could easily owerflow limit causing
>   strange things to happen, ranging from installation failure due to list
>   truncation to complete stack trashing (there is very vague bounds checking).
>   For example, x11/gnome2-fifth-toe runtime dependencies list is 2,418 bytes
>   long.

Why not do it right the first time?  Make it a dynamic buffer
instead of a static one.

Regards,
-- 
wca

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030227205742.GT37397>