Date: Sun, 16 Dec 2007 23:13:20 -0800 From: "Kip Macy" <kip.macy@gmail.com> To: "Sam Leffler" <sam@errno.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Kip Macy <kmacy@freebsd.org>, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet if_ether.c Message-ID: <b1fa29170712162313u1310692dxa64f756c526b37f6@mail.gmail.com> In-Reply-To: <47660A57.8060108@errno.com> References: <200712170419.lBH4JPJg026761@repoman.freebsd.org> <47660A57.8060108@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 16, 2007 9:34 PM, Sam Leffler <sam@errno.com> wrote: > Kip Macy wrote: > > kmacy 2007-12-17 04:19:25 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet if_ether.c > > Log: > > Don't panic in arpresolve if we're given a null mbuf. We could > > insist that the caller just pass in an initialized mbuf even > > if didn't have any data - but that seems rather contrived. > > > > You don't explain the purpose of this change. arpresolve has been > designed for use in the xmit path where there is always an mbuf. This > feels like you are now applying it for a different purpose and it might > be better to define a different api than overload arpresolve's intended > purpose. I will do that. I did it this way because adding an interface felt redundant as I basically need the exact same functionality without the mbuf checks. -Kip
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b1fa29170712162313u1310692dxa64f756c526b37f6>