Date: Thu, 21 May 2015 17:20:59 -0400 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Hiren Panchasara <hiren@freebsd.org>, Lawrence Stewart <lstewart@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283136 - head/sys/netinet Message-ID: <555E4C3B.1060502@FreeBSD.org> In-Reply-To: <20150521200335.GG95600@strugglingcoder.info> References: <201505200108.t4K181No006311@svn.freebsd.org> <555C09D5.9090709@freebsd.org> <20150520042438.GA95600@strugglingcoder.info> <555C2ABC.60102@freebsd.org> <555C89F4.9080607@FreeBSD.org> <555CC40C.1070502@freebsd.org> <20150521200335.GG95600@strugglingcoder.info>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hMmHjDqTwv9kI4CWcf5LPkPLMbHf3A7Du Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 05/21/2015 16:03, Hiren Panchasara wrote: > On 05/21/15 at 03:27P, Lawrence Stewart wrote: >> On 05/20/15 23:19, Eric van Gyzen wrote: >>> On 05/20/2015 02:33, Lawrence Stewart wrote: >>>> On 05/20/15 14:24, Hiren Panchasara wrote: >>>>> On 05/20/15 at 02:13P, Lawrence Stewart wrote: >>>>>> Hi Hiren, >>>>>> >>>>>> On 05/20/15 11:08, Hiren Panchasara wrote: >>>>>>> Author: hiren Date: Wed May 20 01:08:01 2015 New Revision: >>>>>>> 283136 URL: https://svnweb.freebsd.org/changeset/base/283136 >>>>>>> >>>>>>> Log: Add a new sysctl net.inet.tcp.hostcache.purgenow=3D1 to >>>>>>> expire and purge all entries in hostcache immediately. >>>>>>> >>>>>>> In collaboration with: bz, rwatson MFC after: 1 week Relnotes: >>>>>>> yes Sponsored by: Limelight Networks >>>>>> >>>>>> Why introduce a new sysctl and not change the existing behaviour >>>>>> of net.inet.tcp.hostcache.purge? >>>>> >>>>> I thought it'd make more sense to keep the existing behavior as is >>>>> and provide new knob for the new behavior. >>>> >>>> Don't think so - why would deferring a purge to the next purge run b= e >>>> useful compared to purging immediately? I'd strongly suggest you ada= pt >>>> this change to the existing purge sysctl. I can't see why anyone wou= ld >>>> miss the old functionality. >>> >>> I am generally wary of a question such as "Why would anyone want...",= because as soon as the code is released, someone answers it. >>> >>> That being said, I have always wanted Hiren's purgenow behavior, and = I've always been annoyed by the lazy-purge behavior. I would suggest imp= lementing Lawrence's suggestion, but NOT MFC'ing it, since that would be = a disruptive change. >>> >>> Thanks for your work, Hiren. >> >> I see no reason not to MFC it - it's not a POLA violation for a stable= >> branch. When the user requests a purge, it's surely equally as good (a= nd >> I think anyone of right mind would argue better ;) to purge immediatel= y >> than some number of seconds "n" in the future, where "n" is between 1 >> and the value of net.inet.tcp.hostcache.prune. >=20 > I *do* want to MFC the change. And if there are no major objections, I'= ll go > ahead with what Lawrence is suggesting: changing current purge behavior= in -head > and 10. I don't strongly object. I like the new behavior, and I expect most peop= le would, as long as it's clearly stated in the Release Notes (as it will= be, since you tagged it thus). Thanks for your work, Eric --hMmHjDqTwv9kI4CWcf5LPkPLMbHf3A7Du Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJVXkxDXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzRTcwNEY0QTBEMTM0MUU4QkNFNEQ3M0RB RkMxMkExM0VDMjBEQUI4AAoJEK/BKhPsINq43XAH/2zrwJ7OxYdqoZTTM5AC8tIz rNnMjzdNJVr7EsD70bEn94m7DbxhK0Qyt8NM2fMkF+OKi36MuRVx8eh5XjU7LCIE IfxrK0bLMua9vfvC4LvAPpNze5lf/GeX9tAaoRc6twsNfTo8Ei+zUrLuCudgX/kv 3TmPsfKjGIX+IXC9laqb7iT7DhRVzhoT07jZ+qdRQvRolxzVX16Kb2zcZOoIxL2/ mYpK6nv3lYQEbnO+9jbRdgjcu9gaXKnSFh2NbD81w042PDKpAd9mfIWM8aA2BHqg zslNjHK5sC6x4skOEkEFw6aC7UGdr7U90BjawHsOCt9UMj3izFj5DD3WIJG1wnY= =r6f5 -----END PGP SIGNATURE----- --hMmHjDqTwv9kI4CWcf5LPkPLMbHf3A7Du--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?555E4C3B.1060502>