Date: Mon, 28 Sep 2009 15:43:55 +0300 From: Andriy Gapon <avg@icyb.net.ua> To: paradox <ddkprog@yahoo.com> Cc: Alan Cox <alc@freebsd.org>, freebsd-current@freebsd.org, d@delphij.net, Jung-uk Kim <jkim@freebsd.org> Subject: Re: svn commit: r197501 - head/sys/dev/atkbdc Message-ID: <4AC0AF8B.5080401@icyb.net.ua> In-Reply-To: <205895.10887.qm@web59105.mail.re1.yahoo.com> References: <205895.10887.qm@web59105.mail.re1.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
on 25/09/2009 23:07 paradox said the following: > http://svn.freebsd.org/changeset/base/197501 > > would not be bad if someone is from developers who are develop the amd64 looked at the problem this commit > > on arch amd64 > this code > > p = BIOS_PADDRTOVADDR((regs.R_ES << 4) + regs.R_BX); > if ((readb(p + 6) & 0x40) == 0) > > page fault ot access violation when try to readb from p pointer > > R_ES = 0xf000 > R_BX = 0xe6f5 > > as result it is a bios rom area > on arch i386 this works but not work on amd64 It looks like on amd64 BIOS_PADDRTOVADDR should be defined in terms of the direct map. Now, it is a twin of i386 definition. > would be better to use BIOS_PADDRTOVADDR > but we migrate to x86bios_offset to access rom bios area I think that the code, as it is in svn now, does the right thing. Not an expert, perhaps amd64 BIOS_PADDRTOVADDR should be aliased to PHYS_TO_DMAP. Alan, what do you think? -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AC0AF8B.5080401>