Date: Wed, 16 Jul 2014 12:20:59 +0200 From: Carlos Jacobo Puga Medina <cjpugmed@gmail.com> To: freebsd-ports@freebsd.org Subject: Re: Please commit bug 190843 Message-ID: <CAHHLbROy5L1_mmZ10jwr__rTdVoAGMQ_6Kp3Pgtbw9oDF9b8Vw@mail.gmail.com> In-Reply-To: <CAHHLbRNg9wyqO1Ni6KqTTi1DtcFDbPBATpGokUyA13GSfuVsRQ@mail.gmail.com> References: <CAHHLbRPWk6a0p8NQ6RyFzY7j_1VYEzWZMR2mGNF3dDidZz5Euw@mail.gmail.com> <53C3DD16.2040009@FreeBSD.org> <CAHHLbRNg9wyqO1Ni6KqTTi1DtcFDbPBATpGokUyA13GSfuVsRQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2014-07-14 16:36 GMT+02:00 Carlos Jacobo Puga Medina <cjpugmed@gmail.com>: > 2014-07-14 15:37 GMT+02:00 Kubilay Kocak <koobs@freebsd.org>: > > On 14/07/2014 11:23 PM, Carlos Jacobo Puga Medina wrote: >> > Added patch to update to 0.7.0 >> > >> > Build logs: >> > >> > https://redports.org/buildarchive/20140714113400-20929/ >> > >> > --CJPM >> > _______________________________________________ >> > freebsd-ports@freebsd.org mailing list >> > http://lists.freebsd.org/mailman/listinfo/freebsd-ports >> > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org >> " >> > >> >> Thanks for your submission Carlos :) >> >> Our issue tracker is the authoritative source of information for change >> requests, so always include all information there before posting on the >> mailing lists. >> >> I also note that OPTIONS_DEFAULT is added in your patch but has no >> value, so you may want to provide a second version of your patch fixing >> that, including the MAINTAINER update, and posting the URL to your >> redports build in a comment, noting that its ready to commit. >> >> > Fixed. > > >> Running portlint (with -AC) flags is also highly recommended (add the >> output in your comment too, even if its clean) >> >> This gives committers confidence++ that your submission is ready to rock >> >> > Thanks for your useful tips, koobs@ > > >> -- >> koobs >> >> >> >> Kind regards, > > --CJPM > I attached a new patch after r362015 was committed. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190843#c8 --CJPM
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHHLbROy5L1_mmZ10jwr__rTdVoAGMQ_6Kp3Pgtbw9oDF9b8Vw>