Date: Wed, 20 Apr 2016 10:04:47 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: cem@FreeBSD.org Cc: Bruce Evans <brde@optusnet.com.au>, araujo@freebsd.org, John Baldwin <jhb@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r298247 - head/sbin/fdisk_pc98 Message-ID: <3ddd1087-e83a-d14c-1cc2-951a6d23306f@FreeBSD.org> In-Reply-To: <CAG6CVpUnbsgJUbZQzrtWN9mTX3_XBEpQ2ObmcjfF9WjpC9dZCA@mail.gmail.com> References: <201604190446.u3J4kD9G050780@repo.freebsd.org> <4114217.PtcV9LDMal@ralph.baldwin.cx> <CAOfEmZhofgYySTtMKAXo-Qkm8BRaOP8kzEfchdtPTH3T-0W-qQ@mail.gmail.com> <20160420115844.Y967@besplex.bde.org> <c53f4273-d84a-0321-5ba0-d8f99ac6366a@FreeBSD.org> <CAG6CVpUnbsgJUbZQzrtWN9mTX3_XBEpQ2ObmcjfF9WjpC9dZCA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/20/16 09:41, Conrad Meyer wrote: > On Wed, Apr 20, 2016 at 7:33 AM, Pedro Giffuni <pfg@freebsd.org> wrote: >> One of the things I dislike is that most of the macros are in >> lowercase. Lowercase would make sense if these were inline functions >> but inline functions have disadvantages for these use cases. >> OTOH, if they were uppercase, they would not be very easy on the eyes, >> which is the current advantage. > > > You bring up a good point. Obviously nitems() can't be an inline > function, but roundup2() and friends could. Is there any reason not > to change them over to inline functions? > That would be interesting. The question would be if there are type issues. I guess most uses require ints but some many use size_t. If you are willing to try that, have a look at his patch: https://people.freebsd.org/~pfg/patches/sys-roundup2.diff I also have a coccinelle "patch" to replace howmany() and roundup(). Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ddd1087-e83a-d14c-1cc2-951a6d23306f>