Date: Wed, 04 May 2016 20:45:16 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 209270] [igmp] logic error in igmp_v3_suppress_group_record Message-ID: <bug-209270-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209270 Bug ID: 209270 Summary: [igmp] logic error in igmp_v3_suppress_group_record Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: turingsboy@yahoo.com In igmp_v2_suppress_group_record, I see the following: if (inm->inm_state !=3D IGMP_G_QUERY_PENDING_MEMBER || inm->inm_state !=3D IGMP_SG_QUERY_PENDING_MEMBER) return; This is always true due to the logical OR. It looks like it should be this: if (inm->inm_state !=3D IGMP_G_QUERY_PENDING_MEMBER && inm->inm_state !=3D IGMP_SG_QUERY_PENDING_MEMBER) return; I do not know the affect of the change, but the code as written looks=20 very suspiciously like a programming error. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209270-8>