Date: Fri, 9 Sep 2005 13:49:44 -0500 From: "Josh Paetzel" <josh@tcbug.org> To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org> Subject: ports/85922: [patch] Fix tcl dependancy and remove SOCK5 support (which has never worked) Message-ID: <1126291784.0@gimpy.tcbug.org> Resent-Message-ID: <200509091850.j89IoHhp025262@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 85922
>Category: ports
>Synopsis: [patch] Fix tcl dependancy and remove SOCK5 support (which has never worked)
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Sep 09 18:50:17 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Josh Paetzel
>Release: FreeBSD 5.4-RELEASE-p6 i386
>Organization:
>Environment:
System: FreeBSD 5.4-RELEASE-p6 #6: Fri Aug 12 23:13:52 CDT 2005
jpaetzel@gimpy.tcbug.org:/usr/obj/usr/src/sys/GIMPY
>Description:
Fix dependancy errors in regards to tcl support
epic4 has options to use WITH_SOCKS5 in the Makefile. According to the epic developers epic4 has never worked with SOCKS5 support and agree that the SOCKS5 option should be removed from the port.
>How-To-Repeat:
cd /usr/ports/irc/epic4 && make WITH_SOCK5=yes install
Depending on whether tcl is installed or not gives you inconsistant behavior regarding the Makefile switches to use tcl support or not.
>Fix:
Apply the following patch: (essentially the same as the irc/epic5 patch that just got committed)
--- Makefile.old Fri Sep 9 13:02:35 2005
+++ Makefile Fri Sep 9 13:08:41 2005
@@ -34,18 +34,13 @@
CONFIGURE_ARGS+= --without-ipv6
.endif
-## WITH_TCL: enable Tcl support
+## WITHOUT_TCL: disable Tcl support
#
-.if defined(WITH_TCL)
+.if !defined(WITHOUT_TCL)
LIB_DEPENDS+= tcl84:${PORTSDIR}/lang/tcl84
CONFIGURE_ARGS+= --with-tcl
-.endif
-
-## WITH_SOCKS5: enable SOCKS5 support
-#
-.if defined(WITH_SOCKS5)
-LIB_DEPENDS+= socks5:${PORTSDIR}/net/socks5
-CONFIGURE_ARGS+= --with-socks5
+.else
+CONFIGURE_ARGS+= --without-tcl
.endif
## WITH_PERL: enable perl5 support (requires perl 5.6.1 or newer)
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1126291784.0>