Date: Sat, 01 Mar 2008 12:49:23 +0900 (JST) From: haro@kgt.co.jp To: obrien@FreeBSD.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 136469 for review Message-ID: <20080301.124923.69822602.haro@kgt.co.jp> In-Reply-To: <200802291948.m1TJmHX0092569@repoman.freebsd.org> References: <200802291948.m1TJmHX0092569@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
From: "David E. O'Brien" <obrien@FreeBSD.org> Date: Fri, 29 Feb 2008 19:48:17 GMT ::http://perforce.freebsd.org/chv.cgi?CH=136469 :: ::Change 136469 by obrien@obrien_trang on 2008/02/29 00:22:37 :: :: Zero out the new tcb. :: Obtained from: Juniper Networks :: ::Affected files ... :: ::.. //depot/projects/mips2-jnpr/src/lib/libthr/arch/mips/mips/pthread_md.c#3 edit :: ::Differences ... :: ::==== //depot/projects/mips2-jnpr/src/lib/libthr/arch/mips/mips/pthread_md.c#3 (text+ko) ==== :: ::@@ -42,6 +42,7 @@ :: :: tcb = malloc(sizeof(struct tcb)); :: if (tcb) ::+ bzero(tcb, sizeof(struct tcb)); :: tcb->tcb_thread = thread; :: return (tcb); :: } Hi Shouldn't we need '{', '}' around the 'if (tcb)' ? Thanks, Haro =----------------------------------------------------------------------- _ _ Munehiro (haro) Matsuda -|- /_\ |_|_| KGT Inc. /|\ |_| |_|_| 2-8-8 Shinjuku, Shinjuku-ku Tokyo 160-0022, Japan Tel: +81-3-3225-0767 Fax: +81-3-3225-0740
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080301.124923.69822602.haro>