Date: Sun, 5 Sep 2010 22:20:02 GMT From: Alex Samorukov <samm@os2.kiev.ua> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/150235: sysutils/smartmontools build system bug Message-ID: <201009052220.o85MK26b080260@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/150235; it has been noted by GNATS. From: Alex Samorukov <samm@os2.kiev.ua> To: Giorgos Keramidas <keramida@freebsd.org>, Garrett Wollman <wollman@freebsd.org>, bug-followup@freebsd.org, developers@freebsd.org Cc: Subject: Re: ports/150235: sysutils/smartmontools build system bug Date: Mon, 06 Sep 2010 00:11:35 +0200 >> Thats a good point. I can add SRC_BASE variable to the port, with >> /usr/src as default. E.g. emulators/rtc do this way. >> > There is still no guarantee that arbitrary users will have a copy of the > kernel sources anywhere, or that the copy of the kernel sources they have > somewhere will match the actual kernel running on the system. > In this case smartmontools will run without CISSIO support. I don`t see any problems there. > It's also not inconceivable that someone would want to build a port (and/or > make it a package) on another machine than they one they intend to run it on, > with different kernel versions on both machines. > If kernel versions will be different then probably port will simply fail to work, and its absolutely correct behavior. Format of ioctl calls is different in different kernel versions and smartmontools heavily depends on it. > Not to make your life difficult, but depending on the kernel source tree is > not a very good idea. Is there any particular reason the kernel interfaces > you're relying on are not in /usr/include? Because file cissio.h is simply not exists in /usr/include. > Maybe arguing for the headers you > need to be installed and made available to userspace applications would make > more sense than ensuring your application will break in any of a number of > cases? > If i will include this header to the ports than its very easy to break the package in case of ciss driver changes in the kernel. So i`m not sure that its an option.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009052220.o85MK26b080260>