Date: Sat, 05 Mar 2005 22:16:00 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: jeremie@le-hen.org Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/cardbus cardbus.c Message-ID: <20050305.221600.35662653.imp@bsdimp.com> In-Reply-To: <20050306050505.GA71191@obiwan.tataz.chchile.org> References: <200502280127.j1S1ROkh066282@repoman.freebsd.org> <20050306050505.GA71191@obiwan.tataz.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20050306050505.GA71191@obiwan.tataz.chchile.org>
Jeremie Le Hen <jeremie@le-hen.org> writes:
: Hi,
:
: On Mon, Feb 28, 2005 at 01:27:24AM +0000, Warner Losh wrote:
: > imp 2005-02-28 01:27:24 UTC
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/dev/cardbus cardbus.c
: > Log:
: > There were two calls to cardbus_do_cis when cardbus_do_cis changed,
: > yet I only changed one of them. So when we loaded drivers, we'd fail
: > to allocate resources correct.
: >
: > This pointed out that we were doing the wrong thing when we failed to
: > attach a child. We released all the resources and almost deleted the
: > child. Instead, we should keep the resources allocated so when/if a
: > driver is loaded, we can go w/o having to allocate them. We use
: > pci_cfg_save/restore to restore the BARs with these resources.
: >
: > This seems to fix the problems that we were seeing that I thought
: > might have magically gone away in the last revision of cardbus.c (but
: > really didn't).
: >
: > Noticed by: avatar (nicely done!)
: >
: > Revision Changes Path
: > 1.49 +5 -7 src/sys/dev/cardbus/cardbus.c
:
: This commit prevents my rl(4) network card from attaching. Reverting
: to rev 1.48 makes things goes right. Feel free to contact me if you
: need more details.
Attaching how? On kldload or in general? What kind of card do you
have? What messages are involved?
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050305.221600.35662653.imp>