Date: Mon, 30 Mar 2009 16:42:17 +0200 (CEST) From: Emanuel Haupt <ehaupt@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/133207: [update] ports-mgmt/portlint - provide a check for MAKE_JOBS_SAFE in combination with NO_BUILD Message-ID: <200903301442.n2UEgHqR057099@freefall.freebsd.org> Resent-Message-ID: <200903301450.n2UEo10K057200@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 133207
>Category: ports
>Synopsis: [update] ports-mgmt/portlint - provide a check for MAKE_JOBS_SAFE in combination with NO_BUILD
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 30 14:50:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Emanuel Haupt
>Release: FreeBSD 7.1-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD freefall.freebsd.org 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #36: Mon Dec 29 15:15:30 UTC 2008 simon@freefall.freebsd.org:/usr/src/sys/i386/compile/FREEFALL i386
>Description:
Provide a check for MAKE_JOBS_SAFE in combination with NO_BUILD.
MAKE_JOBS_SAFE in combination with NO_BUILD does not make sense.
>How-To-Repeat:
>Fix:
--- portlint.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/ports-mgmt/portlint/Makefile,v
retrieving revision 1.130
diff -u -r1.130 Makefile
--- Makefile 22 Mar 2009 17:54:19 -0000 1.130
+++ Makefile 30 Mar 2009 14:38:35 -0000
@@ -8,7 +8,7 @@
#
PORTNAME= portlint
-PORTVERSION= 2.11.0
+PORTVERSION= 2.12.0
CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
Index: src/portlint.pl
===================================================================
RCS file: /home/pcvs/ports/ports-mgmt/portlint/src/portlint.pl,v
retrieving revision 1.107
diff -u -r1.107 portlint.pl
--- src/portlint.pl 22 Mar 2009 17:54:19 -0000 1.107
+++ src/portlint.pl 30 Mar 2009 14:38:36 -0000
@@ -1541,6 +1541,16 @@
}
#
+ # whole file: MAKE_JOBS_SAFE
+ #
+ print "OK: checking for MAKE_JOBS_SAFE in combination with NO_BUILD.\n" if ($verbose);
+ if ($whole =~ /\nMAKE_JOBS_SAFE.?=/ && $whole =~ /\nNO_BUILD.?=/) {
+ my $lineno = &linenumber($`);
+ &perror("WARN", $file, $lineno, "MAKE_JOBS_SAFE shouldn't be used in combination with NO_BUILD. ".
+ "You should remove MAKE_JOBS_SAFE from your Makefile.");
+ }
+
+ #
# whole file: USE_GETOPT_LONG
#
print "OK: checking for USE_GETOPT_LONG.\n" if ($verbose);
--- portlint.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903301442.n2UEgHqR057099>