Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Oct 2006 17:14:55 GMT
From:      Roman Divacky <rdivacky@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 107430 for review
Message-ID:  <200610071714.k97HEtKK040751@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=107430

Change 107430 by rdivacky@rdivacky_witten on 2006/10/07 17:14:07

	Fix use-after-free. I want to refcount the new undo struct.
	
	Noticed by: netchild

Affected files ...

.. //depot/projects/linuxolator/src/sys/kern/sysv_sem.c#5 edit

Differences ...

==== //depot/projects/linuxolator/src/sys/kern/sysv_sem.c#5 (text+ko) ====

@@ -1272,10 +1272,10 @@
 	refcount_release(&p->p_semundo->refcount);
 	if (p->p_semundo->refcount == 0)
    	   	free(p->p_semundo, M_SEM);
-	refcount_acquire(&p->p_semundo->refcount);
 	PROC_LOCK(p);
 	p->p_semundo = SLIST_NEXT(suptr, un_next);
 	PROC_UNLOCK(p);
+	refcount_acquire(&p->p_semundo->refcount);
 }
 
 static int



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610071714.k97HEtKK040751>