Date: Tue, 01 Apr 2008 22:39:45 +0200 From: Andre Oppermann <andre@freebsd.org> To: Rui Paulo <rpaulo@fnop.net> Cc: freebsd-net@freebsd.org, rpaulo@freebsd.org, Mark Atkinson <atkin901@yahoo.com> Subject: Re: panic: tcp_addoptions: TCP options too long w/ with TCP_SIGNATURE support Message-ID: <47F29D91.6060408@freebsd.org> In-Reply-To: <20080401202005.GB1491@fnop.net> References: <fstmm9$oci$1@ger.gmane.org> <20080401191246.GA1491@fnop.net> <fsu2c6$6iv$1@ger.gmane.org> <47F29471.10901@freebsd.org> <20080401202005.GB1491@fnop.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Rui Paulo wrote: > On Tue, Apr 01, 2008 at 10:00:49PM +0200, Andre Oppermann wrote: >> The order of the TCP options was changed recently to fix another problem. >> This has caused sub-optimal padding and this overflow as not all options >> fit. The tcp_addoptions() loop is not bound internally. >> >> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_output.c?rev=1.146 > > Hmm. Are you sure you wanted to show this revision ? > There's not change for optlen because TCPOLEN_NOP == 1, I think. Oops, wrong URL in paste buffer. Try this: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_var.h.diff?r1=1.160;r2=1.161 -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47F29D91.6060408>