Date: Wed, 17 Mar 2004 09:10:07 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: David Malone <dwmalone@maths.tcd.ie> Cc: freebsd-net@freebsd.org Subject: Re: PPPoE buglet... Message-ID: <Pine.BSF.4.21.0403170908380.72230-100000@InterJet.elischer.org> In-Reply-To: <200403171152.aa43952@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
The RFC is al that matters (except for the compatibility code for idiot suppliers that use the wrong ethertype.) Is there a 110 or 1001 nearby that I may have read in error in the spec? On Wed, 17 Mar 2004, David Malone wrote: > I spent a while trying to get PPPoE going through a Netopia smart > modem last night. To cut a long story short, the values for > PTT_RELAY_SID in src/sys/netgraph/ng_pppoe.h are wrong (at least > when compared with tcpdump, linux and the RFC). We have: > > #if BYTE_ORDER == BIG_ENDIAN > #define PTT_RELAY_SID (0x0106) > #else > #define PTT_RELAY_SID (0x0601) > #endif > > but we should have: > > #if BYTE_ORDER == BIG_ENDIAN > #define PTT_RELAY_SID (0x0110) > #else > #define PTT_RELAY_SID (0x1001) > #endif > > Anyone object to my fixing it? The only thing I can think of that > it might break would be people using ng_pppoe as a PPPoE relay with > only ng_pppoe PPPoE clients. > > David. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0403170908380.72230-100000>