Date: Thu, 31 Oct 2002 20:35:12 -0500 (EST) From: Alan Eldridge <alane@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: naddy@FreeBSD.org Subject: ports/44801: audio/flac: includes /usr/local/include before its own .h files Message-ID: <200211010135.gA11ZCEN003881@wwweasel.geeksrus.net>
next in thread | raw e-mail | index | archive | help
>Number: 44801
>Category: ports
>Synopsis: audio/flac: includes /usr/local/include before its own .h files
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Oct 31 17:40:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Alan Eldridge
>Release: FreeBSD 4.7-STABLE i386
>Organization:
Geeksrus.NET
>Environment:
System: FreeBSD wwweasel.geeksrus.net 4.7-STABLE FreeBSD 4.7-STABLE #0: Wed Oct 30 09:54:05 EST 2002 root@wwweasel.geeksrus.net:/usr/obj/usr/src/sys/LAWYERS_GUNS_AND_MONEY i386
>Description:
Flac includes /usr/local/include in the build before its own .h files. In the
previous update, this was catastriphic - it could not build without the old version being removed first.
>How-To-Repeat:
To show this is happening, I seeded /usr/local/include/FLAC/format.h with a
#error directive. Sure enough, doing the upgrade, I got this:
cc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"flac\" -DVERSION=\"1.0.4\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DFLAC__CPU_IA32=1 -DFLAC__ALIGN_MALLOC_DATA=1 -DFLAC__SSE_OS=1 -DFLAC__USE_3DNOW=1 -DFLAC__HAS_OGG=1 -DHAVE_ICONV=1 -DICONV_CONST=const -DHAVE_LANGINFO_CODESET=1 -DFLAC__HAS_ID3LIB=1 -DID3LIB_MAJOR=3 -DID3LIB_MINOR=7 -DID3LIB_PATCH=13 -DFLAC__HAS_NASM=1 -DSIZEOF_SHORT=2 -DSIZEOF_INT=4 -DSIZEOF_LONG=4 -DSIZEOF_LONG_LONG=8 -I. -I. -I/usr/local/include -I../.. -I./include -I../../include -O -pipe -march=pentiumpro -DNDEBUG -fomit-frame-pointer -funroll-loops -finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__ -c file_decoder.c -Wp,-MD,.deps/file_decoder.TPlo -fPIC -DPIC -o .libs/file_decoder.lo
In file included from /usr/local/include/FLAC/stream_decoder.h:23,
from /usr/local/include/FLAC/seekable_stream_decoder.h:23,
from /usr/local/include/FLAC/file_decoder.h:23,
from include/protected/file_decoder.h:23,
from file_decoder.c:32:
/usr/local/include/FLAC/format.h:24: #error build should not include this file
*** Error code 1
Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4/src/libFLAC.
*** Error code 1
Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4/src/libFLAC.
*** Error code 1
Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4/src.
*** Error code 1
Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4.
*** Error code 1
Stop in /home/bsd/ports/audio/flac.
>Fix:
==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/flac/Makefile,v
retrieving revision 1.19
diff -u -3 -r1.19 Makefile
--- Makefile 31 Oct 2002 19:31:09 -0000 1.19
+++ Makefile 1 Nov 2002 01:24:55 -0000
@@ -39,7 +39,8 @@
CONFIGURE_ARGS+=--enable-sse --enable-3dnow \
--with-libiconv-prefix="${LOCALBASE}" \
--with-ogg="${LOCALBASE}"
-CONFIGURE_ENV= CONFIG_SHELL=${SH}
+CONFIGURE_ENV+= CONFIG_SHELL=${SH}
+CONFIGURE_ENV+= CPPFLAGS="-I${WRKSRC}/include -I${LOCALBASE}/include"
.if defined(NOPORTDOCS)
MAKE_ENV= DOC=""
==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200211010135.gA11ZCEN003881>