Date: Thu, 1 Dec 2005 20:26:10 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <20051201182610.GJ20961@ip.net.ua> In-Reply-To: <20051201.110544.07119736.imp@bsdimp.com> References: <200512011708.jB1H8u3Y065515@repoman.freebsd.org> <20051201172757.GG20961@ip.net.ua> <20051201.110544.07119736.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--QnBU6tTI9sljzm9u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Dec 01, 2005 at 11:05:44AM -0700, M. Warner Losh wrote:
> In message: <20051201172757.GG20961@ip.net.ua>
> Ruslan Ermilov <ru@FreeBSD.ORG> writes:
> : On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote:
> : > imp 2005-12-01 17:08:56 UTC
> : >=20
> : > FreeBSD src repository
> : >=20
> : > Modified files:
> : > . Makefile.inc1=20
> : > Log:
> : > In make buildenv, spell sh as ${SHELL}. In this case, we don't want
> : > to hard code /bin/sh since we're forking it for the user to type
> : > commands into. As such, ${SHELL} is the preferred thing users type
> : > commands into.
> : > =20
> : > Revision Changes Path
> : > 1.524 +1 -1 src/Makefile.inc1
> : >=20
> : Please consider backing it out. In this case, we want to hard code it
> : to "sh" since the stock ~root/.cshrc always resets $PATH, which breaks
> : "make buildenv" for root (which most of us use). Testcase: "which cc"
> : from under "make buildenv" shell.
>=20
> This is an insufficient reason to hard code it to sh. My .cshrc files
> are written properly and make buildenv works. We should consider
> fixing ~root/.cshrc instead to do the right thing with its path. What
> would be wrong with
>=20
> Index: dot.cshrc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/src/etc/root/dot.cshrc,v
> retrieving revision 1.29
> diff -u -r1.29 dot.cshrc
> --- dot.cshrc 1 Apr 2004 19:28:00 -0000 1.29
> +++ dot.cshrc 1 Dec 2005 18:04:01 -0000
> @@ -14,7 +14,7 @@
> # A righteous umask
> umask 22
> =20
> -set path =3D (/sbin /bin /usr/sbin /usr/bin /usr/games /usr/local/sbin /=
usr/local/bin /usr/X11R6/bin $HOME/bin)
> +set path =3D ($path /sbin /bin /usr/sbin /usr/bin /usr/games /usr/local/=
sbin /usr/local/bin /usr/X11R6/bin $HOME/bin)
> =20
> setenv EDITOR vi
> setenv PAGER more
>=20
> I hate enteracting with a sh prompt...
>=20
I hate it too, but I think the PATH setting for root might
have its roots in security (it's not clear from CVS history).
For example, as a user, I have "." in my PATH, but I would
prefer NOT to have it while I'm su'ing to root.
Until we decide how to properly do it, I think unbreaking
"buildenv" for the standard case would be polite.
Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
--QnBU6tTI9sljzm9u
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFDj0BBqRfpzJluFF4RAuKHAJ9efVoS7OhKyLf8Qiu45ttCOXmTRQCdFujL
IRnRytAbpL9645P540NOyRw=
=/6dL
-----END PGP SIGNATURE-----
--QnBU6tTI9sljzm9u--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051201182610.GJ20961>