Date: Fri, 20 Mar 2015 00:02:59 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Antoine Brodin <antoine@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381680 - in head/x11-fonts: font-sun-misc font-winitzki-cyrillic font-xfree86-type1 Message-ID: <20150319230259.GC50017@ivaldir.etoilebsd.net> In-Reply-To: <550B51F1.1010608@FreeBSD.org> References: <201503191940.t2JJevIZ034555@svn.freebsd.org> <550B2916.3090401@FreeBSD.org> <20150319220658.GB50017@ivaldir.etoilebsd.net> <550B51F1.1010608@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6zdv2QT/q3FMhpsV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 19, 2015 at 05:47:13PM -0500, Bryan Drewery wrote: > On 3/19/2015 5:06 PM, Baptiste Daroussin wrote: > > On Thu, Mar 19, 2015 at 02:52:54PM -0500, Bryan Drewery wrote: > >> On 3/19/2015 2:40 PM, Antoine Brodin wrote: > >>> Author: antoine > >>> Date: Thu Mar 19 19:40:56 2015 > >>> New Revision: 381680 > >>> URL: https://svnweb.freebsd.org/changeset/ports/381680 > >>> QAT: https://qat.redports.org/buildarchive/r381680/ > >>> > >>> Log: > >>> Add missing BUILD_DEPENDS and CONFIGURE_ARGS > >>> > >>> Modified: > >>> head/x11-fonts/font-sun-misc/Makefile > >>> head/x11-fonts/font-winitzki-cyrillic/Makefile > >>> head/x11-fonts/font-xfree86-type1/Makefile > >>> > >>> Modified: head/x11-fonts/font-sun-misc/Makefile > >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>> --- head/x11-fonts/font-sun-misc/Makefile Thu Mar 19 19:38:48 2015 (r= 381679) > >>> +++ head/x11-fonts/font-sun-misc/Makefile Thu Mar 19 19:40:56 2015 (r= 381680) > >>> @@ -4,15 +4,18 @@ > >>> PORTNAME=3D font-sun-misc > >>> PORTVERSION=3D 1.0.3 > >>> PORTREVISION=3D 2 > >>> -MASTER_SITES=3D XORG > >>> -MASTER_SITE_SUBDIR=3D individual/font > >>> +MASTER_SITES=3D XORG/individual/font > >>> CATEGORIES=3D x11-fonts > >>> =20 > >>> MAINTAINER=3D x11@FreeBSD.org > >>> COMMENT=3D X.Org miscellaneous Sun fonts > >>> =20 > >>> +BUILD_DEPENDS=3D bdftopcf:${PORTSDIR}/x11-fonts/bdftopcf \ > >>> + mkfontdir:${PORTSDIR}/x11-fonts/mkfontdir > >>> + > >>> USES=3D fonts tar:bzip2 > >>> FONTNAME=3D misc > >>> GNU_CONFIGURE=3D yes > >>> +CONFIGURE_ARGS=3D --with-fontrootdir=3D${PREFIX}/lib/X11/fonts > >>> =20 > >> > >> How is this an improvement over XORG_CAT? There's like 6 more lines th= an > >> before. > >> > >> Should those BUILD_DEPENDS be in fonts.mk? > >=20 > > The improvement is in the fact that XORG_CAT is doing wrong things with= fonts, > > while fonts.mk is not. > >=20 > > Sure I can add an argument to fonts.mk to reduce avoid duplicating thin= gs > >=20 > > Best regards, > > Bapt > >=20 >=20 > Why not fix XORG_CAT? >=20 Because XORG_CAT only works with xorg's fonts not for all fonts while with fonts.mk we can have the same behavious for all fonts (the others fonts are wrong as well) Best regards, Bapt --6zdv2QT/q3FMhpsV Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlULVaMACgkQ8kTtMUmk6EzFGACgshcfwAFFvk6fGAt2jv1r3xcG t6EAn30TBT9nk1WWzFm42JmOfD0TTOze =IFRL -----END PGP SIGNATURE----- --6zdv2QT/q3FMhpsV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150319230259.GC50017>