Date: Tue, 15 Sep 1998 17:12:45 -0700 (PDT) From: dougdougdougdoug@dt053nb4.san.rr.com To: Adrian Penisoara <ady@freebsd.ady.ro> Cc: freebsd-ports@FreeBSD.ORG Subject: Re: ports/7938: Pine Port Upgrade: from 4.02A to 4.03 Message-ID: <Pine.BSF.4.03.9809151655520.26837-100000@dt053nb4.san.rr.com> In-Reply-To: <199809152048.XAA18184@ady.warpnet.ro>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 15 Sep 1998, Adrian Penisoara wrote:
>
> >Number: 7938
> >Category: ports
> >Synopsis: Pine Port Upgrade: from 4.02A to 4.03
I think that you've addressed most of the issues I raised
previously, however before my PR is closed there are one or two nits I'd
like to pick with your latest port.
Your solution of using sed instead of individual patches is a good
one, I considered doing it that way myself but wasn't sure if it would be
accepted or not. Looking at it now, it's a better solution than adding a
lot of one or two line patch files. However, there are a couple files that
you missed. Please add
${WRKSRC}/build
${WRKSRC}/doc/mime.types
${WRKSRC}/pine/init.c
to your list of files for the second sed command.
Also, in the sources there are two files that refer to
/usr/local/pine.conf, pine4.03/doc/tech-notes/background.html and
pine4.03/doc/tech-notes.txt. Personally I consider this a "bug" in the
source. If you are in contact with the developers you might want to
mention this.
It would be nice if you included something to the effect of
diff -ur pine4/work/pine4.03/doc/pine.1 pine4-old/work/pine4.03/doc/pine.1
--- pine4/work/pine4.03/doc/pine.1 Tue Sep 15 15:57:46 1998
+++ pine4-old/work/pine4.03/doc/pine.1 Tue Sep 15 15:50:57 1998
@@ -271,8 +271,6 @@
.br
/etc/mime.types System-wide file ext. to MIME type mapping
.br
-/usr/local/etc/mime.types Optional system-wide file ext. to MIME type
mapping
-.br
/usr/local/etc/pine.info Local pointer to system administrator.
.br
/usr/local/etc/pine.conf System-wide configuration file.
so that the man page reflects the "proper" location for the mime.types
file since the source is now patched to look there.
Finally, this part of the post-install target
${PREFIX}/bin/pine -P ${PREFIX}/etc/pine.conf -conf
>${WRKSRC}/pine.conf
${INSTALL_DATA} ${WRKSRC}/pine.conf ${PREFIX}/etc/pine.conf
indicates to me that you are trying to draw in the existing
/usr/local/etc/pine.conf file and combine that with the new conf file. My
testing indicates that this is not the case, and will result in
overwriting the user's pine.conf file. I still think that my solution to
this problem is better, but I'm biased. :)
I'm glad to see that you've taken my concerns to heart. I don't
want this to appear to be an adversarial undertaking, I think we both have
the same goal in mind, to make the best port possible.
Thanks,
Doug
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.03.9809151655520.26837-100000>