Date: Sat, 5 Jul 2008 13:17:19 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Beech Rintoul <beech@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/atutor Makefile distinfo ports/www/atutor/files pkg-message.in Message-ID: <20080705131719.GB94155@FreeBSD.org> In-Reply-To: <200807050149.m651nKNI017632@repoman.freebsd.org> References: <200807050149.m651nKNI017632@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 05, 2008 at 01:49:20AM +0000, Beech Rintoul wrote: > beech 2008-07-05 01:49:20 UTC > > FreeBSD ports repository > > Modified files: > www/atutor Makefile distinfo > www/atutor/files pkg-message.in > Log: > - Update to 1.6.1 > - Add static plist Couple of stylistic nits: - do-install: seems overly quiet; prepending each and every command is both bogus and silly (there's .SILENT for targets we want quiet) - @${CAT} ${PKGMESSAGE} should probably be surrounded by empty ${ECHO} to be consistent with package vs. port installation. Although this should have probably be handled in less obscure fashion ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080705131719.GB94155>