Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Apr 2004 13:04:49 +0300
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        Luigi Rizzo <luigi@FreeBSD.org>
Cc:        current@FreeBSD.org
Subject:   Recent changes to struct ifnet need to be documented
Message-ID:  <20040405100449.GA478@ip.net.ua>

next in thread | raw e-mail | index | archive | help

--u3/rZRmxL6MmkK24
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Luigi,

I've been bitten by your latest changes to ``struct ifnet''
in the following not-so-uncommon way.  ;)

I've been testing the polling(4) support for the vr(4) driver
the whole day yesterday, and it worked pretty well.  Today
in the morning I've recompiled the if_vr.ko module once again,
and it paniced my system right away.

I've narrowed down the problem to the following: my NFS-mounted
source tree gets updated regularly, and it has already picked
up your changes to ``struct ifnet'' (to remove unused fields).

Since I recompiled only one module, and attempted to run it,
it became incompatible with the running kernel (which still
has the old ``struct ifnet'' layout).

As such, could you please send a HEADS UP to -current saying
that the change introduces backward incompatibility, and
recompile of all network modules is required to catch up
with these changes.  Also, an entry in src/UPDATING would be
in order too.  Perhaps bumping a __FreeBSD_version on behalf
of this change would be a good thing too.  (I'm not sure
about that last one.)

A real solution would be to have kernel somehow check that
modules are ABI compatible with it, and refuse to load those
that aren't.  I'm not sure how to best implement this though.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--u3/rZRmxL6MmkK24
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAcS9BUkv4P6juNwoRAscvAJ4vYpYXcLhXZ5IjLVwWx7yRThgTAACfTgRK
DONRrkRHXL58ndjEtmrpyzg=
=3VIR
-----END PGP SIGNATURE-----

--u3/rZRmxL6MmkK24--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040405100449.GA478>