Date: Wed, 20 Apr 2016 15:27:21 -0700 From: John Baldwin <jhb@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298377 - head/sys/dev/acpica Message-ID: <2347008.OyWmM6azol@ralph.baldwin.cx> In-Reply-To: <201604202121.u3KLLllG091567@repo.freebsd.org> References: <201604202121.u3KLLllG091567@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, April 20, 2016 09:21:47 PM Jung-uk Kim wrote: > Author: jkim > Date: Wed Apr 20 21:21:47 2016 > New Revision: 298377 > URL: https://svnweb.freebsd.org/changeset/base/298377 > > Log: > Remove query flag from acpi_EvaluateOSC(). This function does not support > return buffer (yet). Hmm, I should probably fix that then instead? The PCI variant is (now) incorrectly assuming it gets the buffer back in the array it passed in. The 5.0 spec at least says that the returned values are identical in length to the array passed in. We could either add a new parameter for the outputs or copy them to the inputs. Perhaps the former is better? I'd still prefer to set caps[0] in the common code since it is not UUID-specific but something all _OSC callers have to do. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2347008.OyWmM6azol>