Date: Sat, 26 Jul 2014 23:36:59 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 180668] [ maintainer ] japanese/mutt-devel update to 1.5.21-ja.2 Message-ID: <bug-180668-13-XUn1EzCDJw@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-180668-13@https.bugs.freebsd.org/bugzilla/> References: <bug-180668-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=180668 John Marino <marino@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch Ready |In Discussion --- Comment #1 from John Marino <marino@FreeBSD.org> --- I'm looking at this patch and I see some strange things 1) Lots of comments added to the header. This is not conventional. Maybe in the middle of the makefile, but not at the top. I'm sure you can find other examples but I'm not sure they are smiled upon. 2) COMMENT= changed to COMMENT?= but not clear why. Also comment starts with word "The" but that's not allowed 3) same with MAINTAINER?= 4) why this? DISTFILES= ${DISTNAME}${EXTRACT_SUFX} EXTRACT_ONLY= ${DISTNAME}${EXTRACT_SUFX} Aren't those the defaults? Then I see those augmented later on future lines, but it's not clear why. Is this supposed to be MASTER port? 5) Does the patch still apply? 6) Has it been tested in poudriere, redports, etc? -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-180668-13-XUn1EzCDJw>