Date: Wed, 20 Apr 2016 18:35:42 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r298377 - head/sys/dev/acpica Message-ID: <a506978f-db27-69cc-637a-63ad15ec721d@FreeBSD.org> In-Reply-To: <2347008.OyWmM6azol@ralph.baldwin.cx> References: <201604202121.u3KLLllG091567@repo.freebsd.org> <2347008.OyWmM6azol@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IvcrD46UlnST3vnPuFVsRpv777TQjFpKr Content-Type: multipart/mixed; boundary="cXJvhqlrJF1ec4isfFbLHqkGTQnmS0mWJ" From: Jung-uk Kim <jkim@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <a506978f-db27-69cc-637a-63ad15ec721d@FreeBSD.org> Subject: Re: svn commit: r298377 - head/sys/dev/acpica References: <201604202121.u3KLLllG091567@repo.freebsd.org> <2347008.OyWmM6azol@ralph.baldwin.cx> In-Reply-To: <2347008.OyWmM6azol@ralph.baldwin.cx> --cXJvhqlrJF1ec4isfFbLHqkGTQnmS0mWJ Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04/20/16 06:27 PM, John Baldwin wrote: > On Wednesday, April 20, 2016 09:21:47 PM Jung-uk Kim wrote: >> Author: jkim >> Date: Wed Apr 20 21:21:47 2016 >> New Revision: 298377 >> URL: https://svnweb.freebsd.org/changeset/base/298377 >> >> Log: >> Remove query flag from acpi_EvaluateOSC(). This function does not s= upport >> return buffer (yet). >=20 > Hmm, I should probably fix that then instead? The PCI variant is (now)= > incorrectly assuming it gets the buffer back in the array it passed in.= > The 5.0 spec at least says that the returned values are identical in > length to the array passed in. We could either add a new parameter for= > the outputs or copy them to the inputs. Perhaps the former is better? Yes and yes. > I'd still prefer to set caps[0] in the common code since it is not > UUID-specific but something all _OSC callers have to do. Agreed iff we implement the return buffer. Jung-uk Kim --cXJvhqlrJF1ec4isfFbLHqkGTQnmS0mWJ-- --IvcrD46UlnST3vnPuFVsRpv777TQjFpKr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXGAQ+AAoJEHyflib82/FGkc8H+wYbBgQCLfTzXog501pG1+Se Nl+7B8BKVTWluhD7kd9Qa7K6TLU3Yzfw7EaGDRWVkBXg5o0VoRe+ajnBxmrpxbuD DzSwjm+rsKGxgkNyXqZQAZqqvcc7dqlB9XHZ5pFRIKIca7Hn+vb192//kEpQ9Q5f 2flojHLT6VwH4HsK2ll6Y7Z9Gaa5GLAPxOy5VQ+Z+4vYQSyIpWH6+iBIRIMndoSM Qh6KF/+IjAqSgDtmZWtnaPSPXsJzO5PkKNYViUQ1s7NXoaQGehbM/gSuChiOIXqd HQTmIppCQwUCkcnRgYwOlXf/Ojrt2+aUujIGERLpjGfU0Z9KOeJCIy4c9LHnlIk= =odKD -----END PGP SIGNATURE----- --IvcrD46UlnST3vnPuFVsRpv777TQjFpKr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a506978f-db27-69cc-637a-63ad15ec721d>